Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull latest changes #38

Merged
merged 144 commits into from
Jan 3, 2023
Merged

feat: pull latest changes #38

merged 144 commits into from
Jan 3, 2023

Conversation

1abhishekpandey
Copy link

@1abhishekpandey 1abhishekpandey commented Nov 29, 2022

Description of the change

  • Add context.library object in every message payload.
  • Improve unit test case
  • Add support for channel object in individual payload
  • Add channel=server for every message
  • (Breaking change) Enabled GZIP feature by default.
  • Add CI: Notion PR sync, PR title check, Lint check, Build and unit testing and SonarQube analysis
  • Introduce setDataPlaneUrl and getDataPlaneUrl API's and mark endPoint as deprecated
  • Add tier blocking sample code

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

dependabot bot and others added 30 commits November 1, 2021 16:02
Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.14.0 to 2.17.3.
- [Release notes](https://github.com/diffplug/spotless/releases)
- [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
- [Commits](diffplug/spotless@lib/2.14.0...maven/2.17.3)

---
updated-dependencies:
- dependency-name: com.diffplug.spotless:spotless-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…diffplug.spotless-spotless-maven-plugin-2.17.3

Bump spotless-maven-plugin from 2.14.0 to 2.17.3
… if I should go ahead with implementing changes
…, also checks size for the batch creation and test cases

I have a bunch of comments that i will remove before merge if PR gets approved.
Bumps [okhttp](https://github.com/square/okhttp) from 4.3.0 to 4.9.3.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.3.0...parent-4.9.3)

---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:okhttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
    Added a method to the Analytics Builder class forceTlsVersion1() - name subject to change
    Usage -
            Analytics.Builder builder = Analytics.builder("someKey");
            Analytics analytics = builder.userAgent("someUserAgent")
            .client(someClient)
            .endpoint("some endpoint")
            .anotherAlreadyExistingMethod(someParam)
            .forceTlsVersion1()
            .build();

    this new method forces the httpClient to be created using  ConnectionSpec of MODERN_TLS and including Tls Versions: TLS_1_0, TLS_1_1, TLS_1_2, TLS_1_3

    Also added a simple test case
Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.5.5 to 2.6.2.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v2.5.5...v2.6.2)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-autoconfigure
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps `auto.version` from 1.8.2 to 1.9.

Updates `auto-value` from 1.8.2 to 1.9
- [Release notes](https://github.com/google/auto/releases)
- [Commits](google/auto@auto-value-1.8.2...auto-value-1.9)

Updates `auto-value-annotations` from 1.8.2 to 1.9
- [Release notes](https://github.com/google/auto/releases)
- [Commits](google/auto@auto-value-1.8.2...auto-value-1.9)

---
updated-dependencies:
- dependency-name: com.google.auto.value:auto-value
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.auto.value:auto-value-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bugfix for TLS version error (protocol not supported error)
…squareup.okhttp3-okhttp-4.9.3

Bump okhttp from 4.3.0 to 4.9.3
…springframework.boot-spring-boot-autoconfigure-2.6.2

Bump spring-boot-autoconfigure from 2.5.5 to 2.6.2
Bumps [logging-interceptor](https://github.com/square/okhttp) from 4.9.1 to 4.9.3.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.9.1...parent-4.9.3)

---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:logging-interceptor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…squareup.okhttp3-logging-interceptor-4.9.3

Bump logging-interceptor from 4.9.1 to 4.9.3
Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.9.0.
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.8.1...maven-compiler-plugin-3.9.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps `kotlin.version` from 1.5.31 to 1.6.10.

Updates `kotlin-stdlib` from 1.5.31 to 1.6.10
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.5.31...v1.6.10)

Updates `kotlin-maven-plugin` from 1.5.31 to 1.6.10

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
….version-1.9

Bump auto.version from 1.8.2 to 1.9
…in.version-1.6.10

Bump kotlin.version from 1.5.31 to 1.6.10
Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.21.0 to 3.22.0.
- [Release notes](https://github.com/assertj/assertj-core/releases)
- [Commits](assertj/assertj@assertj-core-3.21.0...assertj-core-3.22.0)

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…apache.maven.plugins-maven-compiler-plugin-3.9.0

Bump maven-compiler-plugin from 3.8.1 to 3.9.0
Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v2.6.2...v2.6.3)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-autoconfigure
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [gson](https://github.com/google/gson) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](google/gson@gson-parent-2.8.8...gson-parent-2.8.9)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.17.3 to 2.20.0.
- [Release notes](https://github.com/diffplug/spotless/releases)
- [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
- [Commits](diffplug/spotless@maven/2.17.3...lib/2.20.0)

---
updated-dependencies:
- dependency-name: com.diffplug.spotless:spotless-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…assertj-assertj-core-3.22.0

Bump assertj-core from 3.21.0 to 3.22.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 4.3.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.12.4...v4.3.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
fixed compile errors: mockito version is upgraded so some methods are not named the same
example: verifyZeroInteractions became verifyNoInteractions
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review December 1, 2022 13:06
@bardisg bardisg changed the base branch from master to develop December 2, 2022 13:47
1abhishekpandey and others added 13 commits December 19, 2022 13:16
Now `channel = server` will be added along with each message payload.
* feat!: bundle the `gzip` support inside the core SDK

Now, GZIP will be enabled by default and have also introduced an API to toggle the GZIP default value, called `enableGZIP`. If user continues to use the `client` API to pass the OkHttpClient then `enableGZIP` API value will not be taken into consideration.

BREAKING CHANGE: Now user who are using the Java SDK, with self-hosted dataPlane and without their own custom `OkHttpClient` (passed using `client` API)` needs to make sure that their server supports GZIP i.e., their server version is above 1.4, else they could either use `enableGZIP` API or pass a custom OkHttpClient instance without the GZIP interceptor.

* refactor: change API name from `enableGZIP` to `setGZIP`
* ci: add build and quality check

* ci: add `PR` title check

* ci: add slack notify check

* ci: implement jacoco report generator, sonarqube, pmd and checkstyle lint check

* ci: skip CI for sample app

* ci: add `build check` and `coverage`  badge to readme file

* ci: fix PMD and checkstyle lint plugin version

* test: fix the MSG_MAX_CREATE_SIZE in AnalyticsClient

Decrease the size by 1, otherwise the test was failing

* ci: add suppression rule for checkstyle

* chore: add feat/latestPull to test the working of build and quality check

Once test completes, revert the change.

* chore: disable badge support

Once test completes, revert the change.

* ci: add `Setup` process for `lint` action

* ci: set `sonar.java.skipUnchanged` to false

To try to remove optimise this log message: `[INFO] The Java analyzer is running in a context where unchanged files can be skipped. Full analysis is performed for changed files, optimized analysis for unchanged files.`

* ci: set `source` and `test` directory for sonar analysis

* ci: set the `exclusion` property for sonar

* ci: set `main` and `test` property for sonar

* ci: comment source and test path for

* chore: try different sonar command

* ci: add jacoco version in pom

* chore: revert sonar command

* chore: trigger CI

* chore: remove comment

* ci: retry badge action

It was producing error earlier, retry now to understand the issue.

* ci: change the name of the action to `Jacoco Badge generator`

* ci: try different action to push the Jacoco report badge

* Revert "ci: try different action to push the Jacoco report badge"

This reverts commit 8f50972.

* ci: try different action to push the Jacoco report badge

* ci: try different action to push the Jacoco report badge

* ci: disable Jacoco badge generator

Having issues (because of EndBug/add-and-commit@v9.1.1) while uploading back the badge to the git branch, hence disabled it. Error log: `Error: Error: fatal: You are not currently on a branch. To push the history leading to the current (detached HEAD) state now, use git push origin HEAD:<name-of-remote-branch>`

* ci: add `Notion PR sync` action

* Revert: remove `feat/latestPull` branch from the action.

This reverts commit: 4d7651f.
As the result of the CI is satisfactory, hence removing the `feat/latestPull`.
This will also disable the CI pipeline for this PR.

* fix: change project name to Java SDK in slack-notify

* ci: remove slack-notify

This is not needed as part of the CI.

* ci(lint): upload lint result to sonarqube
Move the lint to the same job so that lint result gets generated and uploaded to sonarqube
After merging all the PRs, test started failing due to channel=server feature. Hence, decreased the size of the message.
)

* feat: introduce `setDataPlaneUrl` and mark `endPoint` as deprecated

To have uniform behaviour across SDKs, we've decided to mark `endPoint` API as deprecated and replace it with `setDataPlaneUrl` API. In future versions, we'll remove endPoint API.

* refactor: optimise endpoint API logic

* doc: update changelog
* fix: added tier blocking sample code

* fix: tier blocking flush arrival fix

* chore: update blocking flush logic

Now there will be a single phaser to manage the registered parties, and it will handle the max limit (of Phaser) as well.

Co-authored-by: Abhishek Pandey <64667840+1abhishekpandey@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 87 Code Smells

87.1% 87.1% Coverage
2.0% 2.0% Duplication

@bardisg
Copy link

bardisg commented Dec 27, 2022

@debanjan97 can we also include in this all the auto generated PRs for version updated of dependencies?

@1abhishekpandey 1abhishekpandey merged commit c51b6ef into develop Jan 3, 2023
@1abhishekpandey 1abhishekpandey deleted the feat/latestPull branch January 4, 2023 11:44
@1abhishekpandey 1abhishekpandey restored the feat/latestPull branch January 4, 2023 11:51
@ChryssaAliferi ChryssaAliferi deleted the feat/latestPull branch November 7, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants